Fix CI LLVM to work on NixOS out of the box #76667
Conversation
rust-highfive
added
the
S-waiting-on-review
|
Hm, I worry that this is probably not enough. In particular, we also download FileCheck, and if we don't fix that it'll probably break during codegen tests ( For now I'm fine with just explicitly fixing both, though ideally we'd not hard code that.. |
|
r=me with FileCheck fixed as well |
|
@bors r=Mark-Simulacrum rollup |
|
📌 Commit cf07201 has been approved by |
bors
added
S-waiting-on-bors
Fix CI LLVM to work on NixOS out of the box r? @Mark-Simulacrum Tested locally, seems to work!
jyn514
added
T-bootstrap
…as-schievink Rollup of 12 pull requests Successful merges: - rust-lang#75559 (unions: test move behavior of non-Copy fields) - rust-lang#76441 (Note that parallel-compiler = true causes tests to fail) - rust-lang#76527 (Remove internal and unstable MaybeUninit::UNINIT.) - rust-lang#76629 (Simplify iter zip struct doc) - rust-lang#76640 (Simplify SyncOnceCell's `take` and `drop`.) - rust-lang#76646 (Add mailmap entry) - rust-lang#76651 (Remove Windows details from Unix and VmWorks symlink() docstrings) - rust-lang#76663 (Simplify iter chain struct doc) - rust-lang#76665 (slice::from_raw_parts: explicitly mention that data must be initialized) - rust-lang#76667 (Fix CI LLVM to work on NixOS out of the box) - rust-lang#76668 (Add visualization of rustc span in doc) - rust-lang#76677 (note that test_stable_pointers does not reflect a stable guarantee) Failed merges: r? `@ghost`
|
When building the compiler on NixOS with CI LLVM I get: This can be fixed by adding zlib to LD_LIBRARY_PATH. Is this expected, given that this PR says "out of the box"? Am I missing something? |
|
Ah, I am just building with this "kitchen sink" shell.nix: https://github.com/matklad/config/blob/ed3acd6a99eebe5e91df4cf90fa07f35dcaa88dd/shell.nix I think there's a bunch of libs rust needs to build on nixos (I rememeber some ncurses related failures, for example). Not sure if we can fix that in the build. Unlike elfpatching, those things require dependnecies to be installed somewhere. |
|
Oh I see, that makes sense. It's the first time I've had issues I think, but I've not done anything fancy. Would it make sense to include a |
r? @Mark-Simulacrum
Tested locally, seems to work!